Skip to content
Extraits de code Groupes Projets
Valider 5fe115a5 rédigé par mattab's avatar mattab
Parcourir les fichiers

Add integration test for tracking Download and Outlink with fragment

parent 5c73bd13
Aucune branche associée trouvée
Aucune étiquette associée trouvée
Aucune requête de fusion associée trouvée
...@@ -208,8 +208,9 @@ abstract class Action ...@@ -208,8 +208,9 @@ abstract class Action
protected function setActionUrlWithoutExcludingParameters($url) protected function setActionUrlWithoutExcludingParameters($url)
{ {
$this->rawActionUrl = PageUrl::getUrlIfLookValid($url); $url = PageUrl::getUrlIfLookValid($url);
$this->actionUrl = PageUrl::getUrlIfLookValid($url); $this->rawActionUrl = $url;
$this->actionUrl = $url;
} }
abstract protected function getActionsToLookup(); abstract protected function getActionsToLookup();
......
...@@ -59,9 +59,6 @@ class TrackerTest extends IntegrationTestCase ...@@ -59,9 +59,6 @@ class TrackerTest extends IntegrationTestCase
{ {
parent::setUp(); parent::setUp();
GlobalSettingsProvider::unsetSingletonInstance();
Config::unsetInstance();
Fixture::createWebsite('2014-01-01 00:00:00'); Fixture::createWebsite('2014-01-01 00:00:00');
$this->tracker = new TestTracker(); $this->tracker = new TestTracker();
...@@ -253,6 +250,22 @@ class TrackerTest extends IntegrationTestCase ...@@ -253,6 +250,22 @@ class TrackerTest extends IntegrationTestCase
$this->assertActionEquals('example.com', 2); $this->assertActionEquals('example.com', 2);
} }
public function test_trackRequest_shouldTrackOutlinkWithFragment()
{
$request = $this->buildRequest(array('idsite' => 1, 'link' => 'http://example.com/outlink#fragment-here', 'rec' => 1));
$this->tracker->trackRequest($request);
$this->assertActionEquals('http://example.com/outlink#fragment-here', 1);
}
public function test_trackRequest_shouldTrackDownloadWithFragment()
{
$request = $this->buildRequest(array('idsite' => 1, 'download' => 'http://example.com/file.zip#fragment-here&pk_campaign=Campaign param accepted here', 'rec' => 1));
$this->tracker->trackRequest($request);
$this->assertActionEquals('http://example.com/file.zip#fragment-here&pk_campaign=Campaign param accepted here', 1);
}
public function test_main_shouldReturnEmptyPiwikResponse_IfNoRequestsAreGiven() public function test_main_shouldReturnEmptyPiwikResponse_IfNoRequestsAreGiven()
{ {
$requestSet = $this->getEmptyRequestSet(); $requestSet = $this->getEmptyRequestSet();
......
0% Chargement en cours ou .
You are about to add 0 people to the discussion. Proceed with caution.
Terminez d'abord l'édition de ce message.
Veuillez vous inscrire ou vous pour commenter