Fixed small bugs to make it work on a windows server

- error handler now looks for the @ operator that suppresses errors
- in php5 STRICT mode it throws a warning to pass an argument explicitely by reference. The refererence & is only necessary in the function definition
- added some help on how to install PDO on windows when PDO not enabled

git-svn-id: http://dev.piwik.org/svn/trunk@105 59fd770c-687e-43c8-a1e3-f5a4ff64c105

TODO

@@ -15,6 +15,7 @@ SMALL FEATURES
 
 BUGS
 ====
+- set the root password encrypted in the configuration file
 - The numbers in Visits summary seem wrong when compared to phpmyvisites, but the nb of actiosn under the action table for example is correct
   http://ns21996.ovh.net/piwik/?module=Home&action=index&idSite=1&period=day&date=yesterday
 - Purge log_ when archiving is done
@@ -84,12 +85,19 @@ Delete from the SVN files export:
 - libs/phpDocumentor
 - tmp
 
-
+WEBSITE
+=======
+- add le tracking des visites de piwik.org
+- add link to last.zip on the homepage
 
            ------------------
 				Timeline
            ------------------
-           
+To add in some release
+- Update piwik
+- PLugin update
+- API update / backward compatibility
+- Plugins management interface
 
 Todo before alpha public release
 ================================

config/global.ini.php

@@ -13,12 +13,12 @@ adapter			= PDO_MYSQL ; PDO_MYSQL or MYSQLI
 ;profiler 		= false
 
 [database_tests]
-host = localhost
-username = root
-password = nintendo
+host 			= localhost
+username 		= root
+password 		= nintendo
 dbname			= piwiktests
 tables_prefix	= piwiktests_
-adapter = PDO_MYSQL
+adapter 		= PDO_MYSQL
 
 [Language]
 current			= en

index.php

@@ -34,7 +34,6 @@ set_exception_handler('Piwik_ExceptionHandler');
 
 require_once "FrontController.php";
 
-
 $controller = new Piwik_FrontController;
 $controller->init();
 $controller->dispatch();

modules/ErrorHandler.php

@@ -6,11 +6,18 @@
 require_once "Zend/Registry.php"; 
 function Piwik_ErrorHandler($errno, $errstr, $errfile, $errline)
 {
+    // if the error has been suppressed by the @ we don't handle the error
+    if( error_reporting() == 0 )
+    {
+    	return;
+    }
+
     ob_start();
     debug_print_backtrace();
     $backtrace = ob_get_contents();
     ob_end_clean();
     
+    
     try {
     	Zend_Registry::get('logger_error')->log($errno, $errstr, $errfile, $errline, $backtrace);
     }catch(Exception $e){

modules/LogStats/Visit.php

@@ -517,7 +517,7 @@ class Piwik_LogStats_Visit
 			'location_continent' 	=> $continent,
 		);
 		
-		Piwik_PostEvent('LogStats.newVisitorInformation', &$informationToSave);
+		Piwik_PostEvent('LogStats.newVisitorInformation', $informationToSave);
 		
 		$fields = implode(", ", array_keys($informationToSave));
 		$values = substr(str_repeat( "?,",count($informationToSave)),0,-1);

plugins/Installation/templates/systemCheck.tpl

@@ -12,7 +12,21 @@
 	</tr>
 	<tr>
 		<td class="label">Pdo_Mysql extension</td>
-		<td>{if $infos.pdo_mysql_ok}{$ok}{else}{$error}{/if}</td>
+		<td>{if $infos.pdo_mysql_ok}{$ok}
+		
+		{else}{$error}
+		<p class="error" style="width:80%">You need to enable the <code>php_pdo</code> and <code>php_pdo_mysql</code> extensions in your 
+		php.ini file.
+		<br><br><small>On a windows server you can add the lines 
+		<code>extension=php_pdo.dll
+			extension=php_pdo_mysql.dll</code> in your php.ini 
+		</small>
+		</p>
+		{/if}
+		
+		
+		
+		</td>
 	</tr>  
 	<tr>
 		<td class="label">PHP-XML extension <br> (utf8_decode function)</td>