refs #2174 remove access service in favor of writing superUserAccess info...

refs #2174 remove access service in favor of writing superUserAccess info directly into a var as it is just faster and allows us to execute less code

core/Plugin/Controller.php

@@ -546,6 +546,7 @@ abstract class Controller
         $view->debugTrackVisitsInsidePiwikUI = PiwikConfig::getInstance()->Debug['track_visits_inside_piwik_ui'];
         $view->isSuperUser = Access::getInstance()->hasSuperUserAccess();
         $view->hasSomeAdminAccess = Piwik::isUserHasSomeAdminAccess();
+        $view->hasSuperUserAccess = Piwik::hasUserSuperUserAccess();
 
         $customLogo = new CustomLogo();
         $view->isCustomLogo = $customLogo->isEnabled();

plugins/CoreHome/CoreHome.php

@@ -97,7 +97,6 @@ class CoreHome extends \Piwik\Plugin
         $jsFiles[] = "plugins/CoreHome/javascripts/services/service.js";
         $jsFiles[] = "plugins/CoreHome/javascripts/services/piwik-service.js";
         $jsFiles[] = "plugins/CoreHome/javascripts/services/piwik-api-service.js";
-        $jsFiles[] = "plugins/CoreHome/javascripts/services/piwik-access-service.js";
         $jsFiles[] = "plugins/CoreHome/javascripts/services/websitegroups-service.js";
 
         $jsFiles[] = "plugins/CoreHome/javascripts/filters/filter.js";

plugins/CoreHome/javascripts/services/piwik-access-service.js

-/*!
- * Piwik - Web Analytics
- *
- * @link http://piwik.org
- * @license http://www.gnu.org/licenses/gpl-3.0.html GPL v3 or later
- */
-
-angular.module('piwikApp.service').service('piwikAccess', function(piwikApi){
-
-    this.hasSuperUserAccess = false;
-
-    this.fetchHasSuperUserAccess = function () {
-        var that = this;
-
-        piwikApi.fetch({method: 'UsersManager.hasSuperUserAccess'}).then(function (response) {
-            if (response && response.value) {
-                that.hasSuperUserAccess = response.value;
-            }
-            return response;
-        });
-    }
-});
\ No newline at end of file

plugins/Zeitgeist/templates/_jsGlobalVariables.twig

@@ -29,6 +29,7 @@
 {% endif %}
     {% if language is defined %}piwik.language = "{{ language }}";{% endif %}
 
+    piwik.hasSuperUserAccess = {{ hasSuperUserAccess|default(0)|e('js')}};
     piwik.config = {};
 {% if clientSideConfig is defined %}
     piwik.config = {{ clientSideConfig|json_encode|raw }};