Refs #584

 * Remove completely filter_only_display_idgoal from codebase, renamed to idGoal. Appears not to break anything

git-svn-id: http://dev.piwik.org/svn/trunk@5381 59fd770c-687e-43c8-a1e3-f5a4ff64c105

core/API/DataTableGenericFilter.php

@@ -60,8 +60,7 @@ class Piwik_API_DataTableGenericFilter
 						),
 			'AddColumnsProcessedMetricsGoal'	=> array(
 								'filter_update_columns_when_show_all_goals'	=> array('integer'),
-								// third array element names the request variable to check
-								'filter_only_display_idgoal' => array('string', $goalsOverviewConst, 'idGoal'),
+								'idGoal' => array('string', $goalsOverviewConst),
 						),
 			'Sort' => array(
 								'filter_sort_column' 		=> array('string'),
@@ -125,7 +124,7 @@ class Piwik_API_DataTableGenericFilter
 				}
 				
 				try {
-					$value = Piwik_Common::getRequestVar($varName, $defaultValue, $type, $this->request);
+					$value = Piwik_Common::getRequestVar($name, $defaultValue, $type, $this->request);
 					settype($value, $type);
 					$filterParameters[] = $value;
 				}

plugins/Goals/templates/table_by_dimension.tpl

@@ -60,14 +60,13 @@ $(document).ready( function() {
 		widgetUniqueId = module+action;
 		self.expectedWidgetUniqueId = widgetUniqueId;
 		
-		var idGoal = broadcast.getValueFromHash('idGoal');
 		var widgetParameters = {
 			'module': module,
 			'action': action,
 		};
-		if (window.location.hash.indexOf('idGoal') !== -1) {
-			widgetParameters['idGoal'] = idGoal.length ? idGoal : 0;
-		}
+		var idGoal = broadcast.getValueFromHash('idGoal');
+		widgetParameters['idGoal'] = idGoal.length ? idGoal : 0; //Piwik_DataTable_Filter_AddColumnsProcessedMetricsGoal::GOALS_FULL_TABLE;
+		
 		// Loading segment table means loading Goals view for Top Countries/etc.
 		if(module != 'Goals') {
 			widgetParameters['viewDataTable'] = 'tableGoals';