added a test

plugins/Live/.gitignore

+tests/System/processed/*xml
\ No newline at end of file

plugins/Live/tests/Fixtures/ManyVisitsOfSameVisitor.php

+<?php
+/**
+ * Piwik - free/libre analytics platform
+ *
+ * @link    http://piwik.org
+ * @license http://www.gnu.org/licenses/gpl-3.0.html GPL v3 or later
+ */
+namespace Piwik\Plugins\Live\tests\Fixtures;
+
+use Piwik\Date;
+use Piwik\Tests\Framework\Fixture;
+
+/**
+ * Generates many visits for the same visitor
+ */
+class ManyVisitsOfSameVisitor extends Fixture
+{
+    public $dateTime = '2010-02-01 11:22:33';
+    public $idSite = 1;
+
+    public function setUp()
+    {
+        if (!self::siteCreated($idSite = 1)) {
+            self::createWebsite($this->dateTime);
+        }
+
+        $this->trackVisits();
+    }
+
+    public function tearDown()
+    {
+        // empty
+    }
+
+    private function trackVisits()
+    {
+        $t = self::getTracker($this->idSite, $this->dateTime, $defaultInit = true);
+        $t->setTokenAuth(self::getTokenAuth());
+        $t->enableBulkTracking();
+
+        for ($numVisits = 0; $numVisits <= 30; $numVisits++) {
+            $t->setForceNewVisit();
+            $t->setUrl('http://example.org/my/dir/page' . ($numVisits % 4));
+
+            $visitDateTime = Date::factory($this->dateTime)->addDay($numVisits)->getDatetime();
+            $t->setForceVisitDateTime($visitDateTime);
+
+            self::assertTrue($t->doTrackPageView('incredible title ' . ($numVisits % 3)));
+        }
+
+        self::checkBulkTrackingResponse($t->doBulkTrack());
+    }
+}
\ No newline at end of file

plugins/Live/tests/System/APITest.php → plugins/Live/tests/System/APICounterTest.php

@@ -12,17 +12,17 @@ use Piwik\Date;
 use Piwik\Db;
 use Piwik\Plugins\Goals\API as GoalsApi;
 use Piwik\Plugins\Live\API;
-use Piwik\Access;
 use Piwik\Tests\Framework\Fixture;
 use Piwik\Tests\Framework\Mock\FakeAccess;
 use Piwik\Tests\Framework\TestCase\SystemTestCase;
 
 /**
  * @group Live
- * @group APITest
+ * @group ApiTest
+ * @group Api
  * @group Plugins
  */
-class APITest extends SystemTestCase
+class ApiCounterTest extends SystemTestCase
 {
     /**
      * @var API

plugins/Live/tests/System/ApiCounterTest.php

+<?php
+/**
+ * Piwik - free/libre analytics platform
+ *
+ * @link http://piwik.org
+ * @license http://www.gnu.org/licenses/gpl-3.0.html GPL v3 or later
+ */
+
+namespace Piwik\Plugins\Live\tests\System;
+
+use Piwik\Date;
+use Piwik\Db;
+use Piwik\Plugins\Goals\API as GoalsApi;
+use Piwik\Plugins\Live\API;
+use Piwik\Tests\Framework\Fixture;
+use Piwik\Tests\Framework\Mock\FakeAccess;
+use Piwik\Tests\Framework\TestCase\SystemTestCase;
+
+/**
+ * @group Live
+ * @group ApiTest
+ * @group Api
+ * @group Plugins
+ */
+class ApiCounterTest extends SystemTestCase
+{
+    /**
+     * @var API
+     */
+    private $api;
+    private $idSite = 1;
+
+    public function setUp()
+    {
+        parent::setUp();
+
+        $this->api = API::getInstance();
+        $this->setSuperUser();
+        $this->createSite();
+    }
+
+    /**
+     * @expectedException \Exception
+     * @expectedExceptionMessage checkUserHasViewAccess Fake exception
+     */
+    public function test_GetCounters_ShouldFail_IfUserHasNoPermission()
+    {
+        $this->setAnonymous();
+        $this->api->getCounters($this->idSite, 5);
+    }
+
+    public function test_GetCounters_ShouldReturnZeroForAllCounters_IfThereAreNoVisitsEtc()
+    {
+        $counters = $this->api->getCounters($this->idSite, 5);
+
+        $this->assertEquals($this->buildCounter(0, 0, 0, 0), $counters);
+    }
+
+    public function test_GetCounters_ShouldOnlyReturnResultsOfLastMinutes()
+    {
+        $this->trackSomeVisits();
+
+        $counters = $this->api->getCounters($this->idSite, 5);
+        $this->assertEquals($this->buildCounter(19, 32, 16, 16), $counters);
+
+        $counters = $this->api->getCounters($this->idSite, 20);
+        $this->assertEquals($this->buildCounter(24, 60, 20, 40), $counters);
+
+        $counters = $this->api->getCounters($this->idSite, 0);
+        $this->assertEquals($this->buildCounter(0, 0, 0, 0), $counters);
+    }
+
+    public function test_GetCounters_ShouldHideAllColumnsIfRequested()
+    {
+        $exampleCounter = $this->buildCounter(0, 0, 0, 0);
+        $counters = $this->api->getCounters($this->idSite, 5, false, array(), array_keys($exampleCounter[0]));
+        $this->assertEquals(array(array()), $counters);
+    }
+
+    public function test_GetCounters_ShouldHideSomeColumnsIfRequested()
+    {
+        $counters = $this->api->getCounters($this->idSite, 20, false, array(), array('visitsConverted', 'visitors'));
+        $this->assertEquals(array(array('visits' => 24, 'actions' => 60)), $counters);
+    }
+
+    public function test_GetCounters_ShouldShowAllColumnsIfRequested()
+    {
+        $counter = $this->buildCounter(24, 60, 20, 40);
+        $counters = $this->api->getCounters($this->idSite, 20, false, array_keys($counter[0]));
+        $this->assertEquals($counter, $counters);
+    }
+
+    public function test_GetCounters_ShouldShowSomeColumnsIfRequested()
+    {
+        $counters = $this->api->getCounters($this->idSite, 20, false, array('visits', 'actions'));
+        $this->assertEquals(array(array('visits' => 24, 'actions' => 60)), $counters);
+    }
+
+    public function test_GetCounters_ShouldHideColumnIfGivenInShowAndHide()
+    {
+        $counters = $this->api->getCounters($this->idSite, 20, false, array('visits', 'actions'), array('actions'));
+        $this->assertEquals(array(array('visits' => 24)), $counters);
+    }
+
+    private function trackSomeVisits()
+    {
+        $nowTimestamp = time();
+
+        // use local tracker so mock location provider can be used
+        $t = Fixture::getTracker($this->idSite, $nowTimestamp, $defaultInit = true, $useLocal = false);
+        $t->enableBulkTracking();
+
+        for ($i = 0; $i != 20; ++$i) {
+            $t->setForceNewVisit();
+            $t->setVisitorId( substr(md5($i * 1000), 0, $t::LENGTH_VISITOR_ID));
+
+            $factor = 10;
+            if ($i > 15) {
+                $factor = 30; // make sure first 15 visits are always within 5 minutes to prevent any random fails
+            }
+            $time = $nowTimestamp - ($i * $factor);
+
+            // first visit -> this one is > 5 minutes and should be ignored in one test
+            $date = Date::factory($time - 600);
+            $t->setForceVisitDateTime($date->getDatetime());
+            $t->setUrl("http://piwik.net/space/quest/iv");
+            $t->doTrackPageView("Space Quest XV");
+
+            $t->doTrackGoal(1); // this one is > 5 minutes and should be ignored in one test
+
+            // second visit
+            $date = Date::factory($time - 1);
+            $t->setForceVisitDateTime($date->getDatetime());
+            $t->setUrl("http://piwik.net/space/quest/iv");
+            $t->doTrackPageView("Space Quest XII");
+
+            if ($i % 6 == 0) {
+                $t->setForceNewVisit(); // to test visitors vs visits
+            }
+
+            // third visit
+            $date = Date::factory($time);
+            $t->setForceVisitDateTime($date->getDatetime());
+            $t->setUrl("http://piwik.net/grue/$i");
+            $t->doTrackPageView('It is pitch black...');
+
+            $t->doTrackGoal(2);
+        }
+
+        $t->doBulkTrack();
+    }
+
+    private function buildCounter($visits, $actions, $visitors, $visitsConverted)
+    {
+        return array(array(
+            'visits'   => $visits,
+            'actions'  => $actions,
+            'visitors' => $visitors,
+            'visitsConverted' => $visitsConverted,
+        ));
+    }
+
+    private function createSite()
+    {
+        Fixture::createWebsite('2013-01-23 01:23:45');
+        GoalsApi::getInstance()->addGoal(1, 'MyName', 'manually', '', 'contains');
+        GoalsApi::getInstance()->addGoal(1, 'MyGoal', 'manually', '', 'contains');
+    }
+
+    private function setSuperUser()
+    {
+        FakeAccess::$superUser = true;
+    }
+
+    private function setAnonymous()
+    {
+        FakeAccess::clearAccess();
+    }
+
+    public static function provideContainerConfigBeforeClass()
+    {
+        return array(
+            'Piwik\Access' => new FakeAccess()
+        );
+    }
+}

plugins/Live/tests/System/ApiTest.php

+<?php
+/**
+ * Piwik - free/libre analytics platform
+ *
+ * @link http://piwik.org
+ * @license http://www.gnu.org/licenses/gpl-3.0.html GPL v3 or later
+ */
+
+namespace Piwik\Plugins\Live\tests\System;
+
+use Piwik\Plugins\Live\tests\Fixtures\ManyVisitsOfSameVisitor;
+use Piwik\Tests\Framework\TestCase\SystemTestCase;
+
+/**
+ * @group Live
+ * @group ApiTest
+ * @group Api
+ * @group Plugins
+ */
+class ApiTest extends SystemTestCase
+{
+    /**
+     * @var ManyVisitsOfSameVisitor
+     */
+    public static $fixture = null; // initialized below class definition
+
+    /**
+     * @dataProvider getApiForTesting
+     */
+    public function testApi($api, $params)
+    {
+        $this->runApiTests($api, $params);
+    }
+
+    public function getApiForTesting()
+    {
+        $api = array(
+            'Live.getVisitorProfile',
+        );
+
+        $apiToTest   = array();
+        $apiToTest[] = array($api,
+            array(
+                'idSite'     => 1,
+                'date'       => self::$fixture->dateTime,
+                'periods'    => array('day'),
+                'testSuffix' => ''
+            )
+        );
+        $apiToTest[] = array($api,
+            array(
+                'idSite'     => 1,
+                'date'       => self::$fixture->dateTime,
+                'periods'    => array('day'),
+                'otherRequestParameters' => array('limitVisits' => 20),
+                'testSuffix' => 'higherLimit'
+            )
+        );
+
+        return $apiToTest;
+    }
+
+    public static function getOutputPrefix()
+    {
+        return '';
+    }
+
+    public static function getPathToTestDirectory()
+    {
+        return dirname(__FILE__);
+    }
+
+}
+
+ApiTest::$fixture = new ManyVisitsOfSameVisitor();
\ No newline at end of file