refs #4179 use new notification system to display notification

core/Notification.php

@@ -109,7 +109,7 @@ class Notification
     public $priority = self::PRIORITY_LOW;
 
     /**
-     * @param  string $message   The notification message.
+     * @param  string $message   The notification message. Make sure to escape the message if needed.
      * @throws \Exception        In case the message is empty.
      */
     public function __construct($message)

core/Plugin/ControllerAdmin.php

@@ -13,6 +13,7 @@ namespace Piwik\Plugin;
 use Piwik\Config as PiwikConfig;
 use Piwik\Menu\MenuAdmin;
 use Piwik\Menu\MenuTop;
+use Piwik\Notification;
 use Piwik\Piwik;
 use Piwik\Notification\Manager as NotificationManager;
 use Piwik\Url;
@@ -80,8 +81,6 @@ abstract class ControllerAdmin extends Controller
         }
 
         $view->topMenu = MenuTop::getInstance()->getMenu();
-        $view->notifications = NotificationManager::getAllNotificationsToDisplay();
-        NotificationManager::cancelAllNonPersistent();
         $view->currentAdminMenuName = MenuAdmin::getInstance()->getCurrentAdminMenuName();
 
         $view->enableFrames = PiwikConfig::getInstance()->General['enable_framed_settings'];
@@ -100,20 +99,30 @@ abstract class ControllerAdmin extends Controller
             $pluginsLink = Url::getCurrentQueryStringWithParametersModified(array(
                                                                                  'module' => 'CorePluginsAdmin', 'action' => 'plugins'
                                                                             ));
-            $view->invalidPluginsWarning = Piwik::translate('CoreAdminHome_InvalidPluginsWarning', array(
+            $invalidPluginsWarning = Piwik::translate('CoreAdminHome_InvalidPluginsWarning', array(
                                                                                                        self::getPiwikVersion(),
                                                                                                        '<strong>' . implode('</strong>,&nbsp;<strong>', $missingPlugins) . '</strong>'))
-                . '<br/>'
                 . Piwik::translate('CoreAdminHome_InvalidPluginsYouCanUninstall', array(
                                                                                       '<a href="' . $pluginsLink . '"/>',
                                                                                       '</a>'
                                                                                  ));
+
+            if (Piwik::isUserIsSuperUser()) {
+                $notification = new Notification($invalidPluginsWarning);
+                $notification->context = Notification::CONTEXT_WARNING;
+                $notification->title   = Piwik::translate('General_Warning') . ':';
+                $notification->flags   = Notification::FLAG_NO_CLEAR;
+                Notification\Manager::notify('ControllerAdmin_InvalidPluginsWarning', $notification);
+            }
         }
 
         self::checkPhpVersion($view);
 
         $adminMenu = MenuAdmin::getInstance()->getMenu();
         $view->adminMenu = $adminMenu;
+
+        $view->notifications = NotificationManager::getAllNotificationsToDisplay();
+        NotificationManager::cancelAllNonPersistent();
     }
 
     static protected function getPiwikVersion()

plugins/CoreHome/stylesheets/notification.less

@@ -10,7 +10,7 @@
   color: #9b7a44;
   float: none;
 
-  padding: 10px 35px 10px 14px;
+  padding: 15px 35px 15px 15px;
   text-shadow: 0 1px 0 rgba(255,255,255,.5);
   background-color: #ffffe0;
   border: 1px solid #e6db55;

plugins/Zeitgeist/templates/admin.twig

@@ -61,13 +61,6 @@
 
                     {% include "@CoreHome/_warningInvalidHost.twig" %}
 
-                    {# missing plugins warning #}
-                    {% if isSuperUser and invalidPluginsWarning is defined %}
-                    <div class="ajaxSuccess">
-                        <strong>{{ 'General_Warning'|translate }}:&nbsp;</strong>{{ invalidPluginsWarning|raw }}
-                    </div>
-                    {% endif %}
-
                     {# old GeoIP plugin warning #}
                     {% if isSuperUser and usingOldGeoIPPlugin is not empty %}
                     <div class="ajaxSuccess">