Skip to content
Extraits de code Groupes Projets
Valider ba613143 rédigé par Matthieu Aubry's avatar Matthieu Aubry
Parcourir les fichiers

Exclude some vendor files from tests and ensure enough files were tested


fixing this integration test: https://travis-ci.org/piwik/piwik/jobs/108227278
parent b9d772e4
Branches
Aucune étiquette associée trouvée
Aucune requête de fusion associée trouvée
......@@ -622,12 +622,17 @@ class ReleaseCheckListTest extends \PHPUnit_Framework_TestCase
$this->assertEquals('20', bin2hex(' '), "Checking that this test file was not tampered with");
$errors = array();
$countFileChecked = 0;
foreach ($files as $file) {
if($this->isFileBelongToTests($file)) {
continue;
}
if(strpos($file, 'vendor/php-di/php-di/website/') !== false) {
continue;
}
$content = file_get_contents($file);
$posWeirdSpace = strpos($content, $weirdSpace);
if ($posWeirdSpace !== false) {
......@@ -635,7 +640,11 @@ class ReleaseCheckListTest extends \PHPUnit_Framework_TestCase
$around = trim($around);
$errors[] = "File $file contains an unusual space character, please remove it from here: ...$around...";
}
$countFileChecked++;
}
$this->assertTrue($countFileChecked > 100, "expected to test at least 100 files, but tested only " . $countFileChecked);
if (!empty($errors)) {
throw new Exception(implode(",\n\n ", $errors));
}
......
0% Chargement en cours ou .
You are about to add 0 people to the discussion. Proceed with caution.
Veuillez vous inscrire ou vous pour commenter