Show confirmation before giving view access to anonymous user (#11744)

* Show confirmation before giving view access to anonymous user

* Remove unneeded usage of raw template filter

plugins/UsersManager/angularjs/give-user-view-access/give-user-view-access.controller.js

@@ -133,7 +133,15 @@
             if (idSites === 'all') {
                 setViewAccessForUserToAllWebsitesIfUserConfirms(userLogin);
             } else {
-                setViewAccessForUserIfNotAlreadyHasAccess(userLogin, idSites);
+                function onValidate() {
+                    setViewAccessForUserIfNotAlreadyHasAccess(userLogin, idSites);
+                }
+
+                if (userLogin == 'anonymous') {
+                    piwikHelper.modalConfirm('#confirmAnonymousAccess', {yes: onValidate, no: hideLoading})
+                } else {
+                    onValidate();
+                }
             }
         }
 

plugins/UsersManager/angularjs/manage-user-access/manage-user-access.controller.js

@@ -104,19 +104,22 @@
                 }
             }
 
-            if (this.site.id == 'all') {
+            function onValidate() {
+                launchAjaxRequest(login, access).then(successCallback);
+            }
+
+            if (login == 'anonymous' && access == 'view') {
+                piwikHelper.modalConfirm('#confirmAnonymousAccess', {yes: onValidate})
+            }
+            else if (this.site.id == 'all') {
 
                 //ask confirmation
                 $('#confirm').find('.login').text(login);
 
-                function onValidate() {
-                    launchAjaxRequest(login, access).then(successCallback);
-                }
-
                 piwikHelper.modalConfirm('#confirm', {yes: onValidate})
             }
             else {
-                launchAjaxRequest(login, access).then(successCallback);
+                onValidate();
             }
         }
     }

plugins/UsersManager/lang/en.json

@@ -3,6 +3,7 @@
         "AddUser": "Add a new user",
         "Alias": "Alias",
         "AllWebsites": "All websites",
+        "AnonymousAccessConfirmation": "You are about to grant the anonymous user the 'view' access to this website. This means your analytics reports and your visitors information will be publicly viewable by anyone even without a login. Are you sure you want to proceed?",
         "AnonymousUser": "Anonymous user",
         "AnonymousUserHasViewAccess": "Note: the %1$s user has %2$s access to this website.",
         "AnonymousUserHasViewAccess2": "Your analytics reports and your visitors information are publicly viewable.",

plugins/UsersManager/templates/index.twig

@@ -162,6 +162,12 @@
     <input role="no" type="button" value="{{ 'General_No'|translate }}"/>
 </div>
 
+<div class="ui-confirm" id="confirmAnonymousAccess">
+    <h2>{{ 'UsersManager_AnonymousAccessConfirmation'|translate }}</h2>
+    <input role="yes" type="button" value="{{ 'General_Yes'|translate }}"/>
+    <input role="no" type="button" value="{{ 'General_No'|translate }}"/>
+</div>
+
 {% if userIsSuperUser %}
 <div piwik-content-block content-title="{{ 'UsersManager_UsersManagement'|translate|e('html_attr') }}">
     <div class="ui-confirm" id="confirmUserRemove">