Skip to content
Extraits de code Groupes Projets
Valider d2924407 rédigé par mattab's avatar mattab
Parcourir les fichiers

Fix tests

parent f3575224
Aucune branche associée trouvée
Aucune étiquette associée trouvée
Aucune requête de fusion associée trouvée
......@@ -9,9 +9,10 @@
namespace Piwik\Plugins\Actions\Columns;
use Piwik\Piwik;
use Piwik\Plugin\Dimension\ActionDimension;
use Piwik\Plugins\Actions\Segment;
class ClickedUrl extends PageUrl
class ClickedUrl extends ActionDimension
{
public function getName()
{
......@@ -23,6 +24,7 @@ class ClickedUrl extends PageUrl
$segment = new Segment();
$segment->setSegment('outlinkUrl');
$segment->setName('Actions_ColumnClickedURL');
$segment->setSqlSegment('log_link_visit_action.idaction_url');
$this->addSegment($segment);
}
......
......@@ -9,9 +9,10 @@
namespace Piwik\Plugins\Actions\Columns;
use Piwik\Piwik;
use Piwik\Plugin\Dimension\ActionDimension;
use Piwik\Plugins\Actions\Segment;
class DownloadUrl extends PageUrl
class DownloadUrl extends ActionDimension
{
public function getName()
{
......@@ -23,6 +24,7 @@ class DownloadUrl extends PageUrl
$segment = new Segment();
$segment->setSegment('downloadUrl');
$segment->setName('Actions_ColumnDownloadURL');
$segment->setSqlSegment('log_link_visit_action.idaction_url');
$this->addSegment($segment);
}
......
......@@ -11,6 +11,7 @@ namespace Piwik\Tests\Core\DataTable\Filter;
use Piwik\DataTable;
use Piwik\DataTable\Row;
use Piwik\Plugins\Actions\Reports\GetOutlinks;
use Piwik\Plugins\DevicePlugins\Reports\GetPlugin;
use Piwik\Plugins\UserCountry\Reports\GetCity;
use Piwik\Plugins\UserCountry\Reports\GetCountry;
use Piwik\Plugins\VisitsSummary\Reports\Get;
......@@ -97,8 +98,8 @@ class AddSegmentBySegmentValueTest extends \PHPUnit_Framework_TestCase
public function test_filter_shouldNotGenerateASegment_IfDimensionHasNoSegmentFilter()
{
// outlinks currently has a dimensions but no segments, we have to use another report once it has segments
$report = new GetOutlinks();
// plugin report currently has a dimensions but no segments, we have to use another report if later we add segments
$report = new GetPlugin();
$this->assertEmpty($report->getDimension()->getSegments());
$this->assertSegmentForSegmentValueAndReport($report, $segmentValue = 'existing', false);
......
0% Chargement en cours ou .
You are about to add 0 people to the discussion. Proceed with caution.
Terminez d'abord l'édition de ce message.
Veuillez vous inscrire ou vous pour commenter