Fixing post merge bugs

core/Controller.php

@@ -30,9 +30,8 @@ use Piwik\Url;
 use Piwik_UsersManager_API;
 use Piwik\View;
 use Piwik\ViewDataTable;
-use Piwik\ViewDataTable\GenerateGraphHtml\ChartEvolution;
+use Piwik\ViewDataTable\GenerateGraphHTML\ChartEvolution;
 use Zend_Registry;
-use false;
 
 /**
  * Parent class of all plugins Controllers (located in /plugins/PluginName/Controller.php

core/ViewDataTable/GenerateGraphHTML/ChartEvolution.php

@@ -9,7 +9,7 @@
  * @package Piwik
  */
 
-namespace Piwik\ViewDataTable\GenerateGraphHtml;
+namespace Piwik\ViewDataTable\GenerateGraphHTML;
 
 use Piwik\Common;
 use Piwik\Period\Range;

core/ViewDataTable/GenerateGraphHTML/ChartPie.php

@@ -8,7 +8,7 @@
  * @category Piwik
  * @package Piwik
  */
-namespace Piwik\ViewDataTable\GenerateGraphHtml;
+namespace Piwik\ViewDataTable\GenerateGraphHTML;
 
 use Piwik\ViewDataTable\GenerateGraphHTML;
 

core/ViewDataTable/GenerateGraphHTML/ChartVerticalBar.php

@@ -8,8 +8,7 @@
  * @category Piwik
  * @package Piwik
  */
-namespace Piwik\ViewDataTable\GenerateGraphHtml;
-
+namespace Piwik\ViewDataTable\GenerateGraphHTML;
 use Piwik\ViewDataTable\GenerateGraphHTML;
 
 /**

core/ViewDataTable/Sparkline.php

@@ -14,7 +14,6 @@ use Exception;
 use Piwik\Common;
 use Piwik\DataTable;
 use Piwik\ViewDataTable;
-use Piwik\Visualization\Sparkline;
 
 /**
  * Reads the requested DataTable from the API and prepare data for the Sparkline view.
@@ -54,7 +53,7 @@ class Sparkline extends ViewDataTable
             $values = array_fill(0, 30, 0);
         }
 
-        $graph = new Sparkline();
+        $graph = new \Piwik\Visualization\Sparkline();
         $graph->setValues($values);
 
         $height = Common::getRequestVar('height', 0, 'int');

core/functions.php

@@ -256,9 +256,10 @@ namespace {
         Top::getInstance()->rename($topMenuOriginal, null, $topMenuRenamed, null);
     }
 
-    if(class_exists('DataTableSummaryRow')) {
-
-        // Bridge between pre Piwik2 serialized format and namespaced classes
+    // Bridge between pre Piwik2 serialized format and namespaced classes
+    // Do not define these classes in tracker or archive
+    if(empty($GLOBALS['PIWIK_TRACKER_MODE'])
+        && !defined('PIWIK_MODE_ARCHIVE')) {
         class Piwik_DataTable_Row_DataTableSummary extends \Piwik\DataTable\Row\DataTableSummaryRow {
         }
 

misc/cron/archive.php

@@ -63,7 +63,9 @@ define('PIWIK_USER_PATH', PIWIK_INCLUDE_PATH);
 define('PIWIK_ENABLE_DISPATCH', false);
 define('PIWIK_ENABLE_ERROR_HANDLER', false);
 define('PIWIK_ENABLE_SESSION_START', false);
-define('PIWIK_MODE_ARCHIVE', true);
+if(!defined('PIWIK_MODE_ARCHIVE')) {
+    define('PIWIK_MODE_ARCHIVE', true);
+}
 
 require_once PIWIK_INCLUDE_PATH . "/index.php";
 require_once PIWIK_INCLUDE_PATH . "/core/API/Request.php";

plugins/CoreHome/DataTableRowAction/RowEvolution.php

@@ -15,7 +15,7 @@ use Piwik\Metrics;
 use Piwik\Date;
 use Piwik\ViewDataTable;
 use Piwik\Url;
-use Piwik\ViewDataTable\GenerateGraphHtml\ChartEvolution;
+use Piwik\ViewDataTable\GenerateGraphHTML\ChartEvolution;
 use Piwik\Visualization\Chart\Evolution;
 
 /**

tests/PHPUnit/TestingEnvironment.php

 <?php
 
+if (!defined('PIWIK_TEST_MODE')) {
+    define('PIWIK_TEST_MODE', true);
+}
+
 /**
  * Sets the test environment.
  */
@@ -7,9 +11,6 @@ class Piwik_TestingEnvironment
 {
     public static function addHooks()
     {
-        if (!defined('PIWIK_TEST_MODE')) {
-            define('PIWIK_TEST_MODE', true);
-        }
         Piwik_AddAction('Access.createAccessSingleton', function($access) {
             $access->setSuperUser(true);
         });

tests/PHPUnit/proxy/archive.php

 <?php
+define('PIWIK_MODE_ARCHIVE', true);
 
 // make sure the test environment is loaded
 require_once realpath(dirname(__FILE__)) . '/../../../core/EventDispatcher.php';