Skip to content
Extraits de code Groupes Projets
Valider e2e76165 rédigé par mattab's avatar mattab Validation de Thomas Steur
Parcourir les fichiers

Update comments and function name (minor)

parent bcf12baf
Aucune branche associée trouvée
Aucune étiquette associée trouvée
Aucune requête de fusion associée trouvée
...@@ -105,11 +105,10 @@ class OneVisitorOneWebsiteSeveralDaysDateRangeArchivingTest extends SystemTestCa ...@@ -105,11 +105,10 @@ class OneVisitorOneWebsiteSeveralDaysDateRangeArchivingTest extends SystemTestCa
// so we only archived the parent table // so we only archived the parent table
$expectedActionsBlobs = 5; $expectedActionsBlobs = 5;
// When flat=1, Actions plugin will process 5 + 3 extra blobs (URL = 'http://example.org/sub1/sub2/sub3/news') // When flat=1, Actions plugin will process 5 + 1 extra chunk blobs (URL = 'http://example.org/sub1/sub2/sub3/news')
$expectedActionsBlobsWhenFlattened = $expectedActionsBlobs + 1; $expectedActionsBlobsWhenFlattened = $expectedActionsBlobs + 1;
$tests = array( $tests = array(
// TODO Implement fix, then remove the +3 below
'archive_blob_2010_12' => ( ($expectedActionsBlobs+1) /*Actions*/ 'archive_blob_2010_12' => ( ($expectedActionsBlobs+1) /*Actions*/
+ 2 /* Resolution */ + 2 /* Resolution */
+ 2 /* VisitTime */) * 3, + 2 /* VisitTime */) * 3,
......
...@@ -76,7 +76,7 @@ class TwoVisitsWithCustomVariablesSegmentMatchVisitorTypeTest extends SystemTest ...@@ -76,7 +76,7 @@ class TwoVisitsWithCustomVariablesSegmentMatchVisitorTypeTest extends SystemTest
// 1) CHECK 'day' archive stored in January // 1) CHECK 'day' archive stored in January
// We expect 2 segments // We expect 2 segments
// * (1 custom variable name + 2 ref metrics // * (1 custom variable name + 2 ref metrics
// + 1 subtable for the custom var values + 5 Referrers blob (2 of them subtables) // + 1 subtable chunk for the custom var values + 5 Referrers blob (2 of them subtables)
// ) // )
'archive_blob_2010_01' => 18, 'archive_blob_2010_01' => 18,
// This contains all 'last N' weeks & days, // This contains all 'last N' weeks & days,
...@@ -88,7 +88,7 @@ class TwoVisitsWithCustomVariablesSegmentMatchVisitorTypeTest extends SystemTest ...@@ -88,7 +88,7 @@ class TwoVisitsWithCustomVariablesSegmentMatchVisitorTypeTest extends SystemTest
'archive_numeric_2010_01' => 138, 'archive_numeric_2010_01' => 138,
// 2) CHECK 'week' archive stored in December (week starts the month before) // 2) CHECK 'week' archive stored in December (week starts the month before)
// We expect 2 segments * (1 custom variable name + 2 ref metrics + 1 subtable for the values of the name + 5 referrers blob (2 of them subtables)) // We expect 2 segments * (1 custom variable name + 2 ref metrics + 1 subtable chunk for the values of the name + 5 referrers blob (2 of them subtables))
'archive_blob_2009_12' => 18, 'archive_blob_2009_12' => 18,
// 7 metrics, // 7 metrics,
// 2 Referrer metrics (Referrers_distinctSearchEngines/Referrers_distinctKeywords), // 2 Referrer metrics (Referrers_distinctSearchEngines/Referrers_distinctKeywords),
......
...@@ -61,7 +61,7 @@ class RowTest extends \PHPUnit_Framework_TestCase ...@@ -61,7 +61,7 @@ class RowTest extends \PHPUnit_Framework_TestCase
$this->assertEquals(null, $testRow->getIdSubDataTable()); $this->assertEquals(null, $testRow->getIdSubDataTable());
} }
public function test_desctruct_ShouldRemoveASetSubtable() public function test_destruct_ShouldRemoveASetSubtable()
{ {
$testRow = $this->getTestRowWithSubDataTableLoaded(); $testRow = $this->getTestRowWithSubDataTableLoaded();
$this->assertTrue($testRow->isSubtableLoaded()); $this->assertTrue($testRow->isSubtableLoaded());
......
0% Chargement en cours ou .
You are about to add 0 people to the discussion. Proceed with caution.
Veuillez vous inscrire ou vous pour commenter