Skip to content
Extraits de code Groupes Projets
Valider e6e36681 rédigé par sgiehl's avatar sgiehl
Parcourir les fichiers

removing extra comma in pull request title when no languages were added

parent 1d991a52
Aucune branche associée trouvée
Aucune étiquette associée trouvée
Aucune requête de fusion associée trouvée
......@@ -115,24 +115,23 @@ class CreatePull extends ConsoleCommand
preg_match_all('/M lang\/([a-z]{2,3})\.json/', $changes, $modifiedFiles);
preg_match_all('/A lang\/([a-z]{2,3})\.json/', $changes, $addedFiles);
$modifiedList = '';
$lnaguageCodesTouched = array();
if (!empty($modifiedFiles[1])) {
foreach ($modifiedFiles[1] AS $modifiedFile) {
$fileCount++;
$languageInfo = $this->getLanguageInfoByIsoCode($modifiedFile);
$message .= sprintf('- Updated %s (%s translated)\n', $languageInfo['english_name'], $languageInfo['percentage_complete']);
}
$modifiedList = implode(', ', $modifiedFiles[1]);
$lnaguageCodesTouched = $modifiedFiles[1];
}
$addedList = '';
if (!empty($addedFiles[1])) {
foreach ($addedFiles[1] AS $addedFile) {
$fileCount++;
$languageInfo = $this->getLanguageInfoByIsoCode($addedFile);
$message .= sprintf('- Added %s (%s translated)\n', $languageInfo['english_name'], $languageInfo['percentage_complete']);
}
$addedList = implode(', ', $addedFiles[1]);
$lnaguageCodesTouched = array_merge($lnaguageCodesTouched, $addedFiles[1]);
}
$stats = shell_exec('git diff --numstat HEAD lang');
......@@ -148,7 +147,7 @@ class CreatePull extends ConsoleCommand
'Updated %s strings in %u languages (%s)',
$addedLinesSum,
$fileCount,
implode(', ', array($modifiedList, $addedList))
implode(', ', $lnaguageCodesTouched)
);
shell_exec('git commit -m "language update ${pluginName} refs #3430"');
......
0% Chargement en cours ou .
You are about to add 0 people to the discussion. Proceed with caution.
Terminez d'abord l'édition de ce message.
Veuillez vous inscrire ou vous pour commenter