removed unused variables

core/API/DocumentationGenerator.php

@@ -79,9 +79,8 @@ class DocumentationGenerator
                     if ($exampleUrl !== false) {
                         $lastNUrls = '';
                         if (preg_match('/(&period)|(&date)/', $exampleUrl)) {
-                            $exampleUrlRss1 = $prefixUrls . $this->getExampleUrl($class, $methodName, array('date' => 'last10', 'period' => 'day') + $parametersToSet);
-                            $exampleUrlRss2 = $prefixUrls . $this->getExampleUrl($class, $methodName, array('date' => 'last5', 'period' => 'week',) + $parametersToSet);
-                            $lastNUrls = ",	RSS of the last <a target=_blank href='$exampleUrlRss1&format=rss$token_auth&translateColumnNames=1'>10 days</a>";
+                            $exampleUrlRss = $prefixUrls . $this->getExampleUrl($class, $methodName, array('date' => 'last10', 'period' => 'day') + $parametersToSet);
+                            $lastNUrls = ",	RSS of the last <a target=_blank href='$exampleUrlRss&format=rss$token_auth&translateColumnNames=1'>10 days</a>";
                         }
                         $exampleUrl = $prefixUrls . $exampleUrl;
                         $str .= " [ Example in

core/API/ResponseBuilder.php

@@ -400,7 +400,7 @@ class ResponseBuilder
         $first = reset($array);
         foreach ($array as $first) {
             if (is_array($first)) {
-                foreach ($first as $key => $value) {
+                foreach ($first as $value) {
                     // Yes, this is a multi dim array
                     if (is_array($value)) {
                         switch ($this->outputFormat) {

core/CronArchive.php

@@ -1169,7 +1169,7 @@ class CronArchive
     private function logFatalErrorUrlExpected()
     {
         $this->logFatalError("./console core:archive expects the argument 'url' to be set to your Piwik URL, for example: --url=http://example.org/piwik/ "
-            . "\n--help for more information", $backtrace = false);
+            . "\n--help for more information");
     }
 
     private function getVisitsLastPeriodFromApiResponse($stats)

core/DataAccess/LogAggregator.php

@@ -662,7 +662,7 @@ class LogAggregator
 
     protected function getActionsMetricFields()
     {
-        return $availableMetrics = array(
+        return array(
             Metrics::INDEX_NB_VISITS        => "count(distinct " . self::LOG_ACTIONS_TABLE . ".idvisit)",
             Metrics::INDEX_NB_UNIQ_VISITORS => "count(distinct " . self::LOG_ACTIONS_TABLE . ".idvisitor)",
             Metrics::INDEX_NB_ACTIONS       => "count(*)",

core/DataArray.php

@@ -332,7 +332,7 @@ class DataArray
      */
     protected function enrichWithConversions(&$data)
     {
-        foreach ($data as $label => &$values) {
+        foreach ($data as &$values) {
             if (!isset($values[Metrics::INDEX_GOALS])) {
                 continue;
             }

core/DataTable.php

@@ -1026,7 +1026,6 @@ class DataTable implements DataTableInterface
     public static function isEqual(DataTable $table1, DataTable $table2)
     {
         $rows1 = $table1->getRows();
-        $rows2 = $table2->getRows();
 
         $table1->rebuildIndex();
         $table2->rebuildIndex();

core/DataTable/Filter/ColumnCallbackAddColumnQuotient.php

@@ -75,7 +75,7 @@ class ColumnCallbackAddColumnQuotient extends BaseFilter
      */
     public function filter($table)
     {
-        foreach ($table->getRows() as $key => $row) {
+        foreach ($table->getRows() as $row) {
             $value = $this->getDividend($row);
             if ($value === false && $this->shouldSkipRows) {
                 continue;

core/DataTable/Filter/ColumnCallbackReplace.php

@@ -72,7 +72,7 @@ class ColumnCallbackReplace extends BaseFilter
      */
     public function filter($table)
     {
-        foreach ($table->getRows() as $key => $row) {
+        foreach ($table->getRows() as $row) {
             $extraColumnParameters = array();
             foreach ($this->extraColumnParameters as $columnName) {
                 $extraColumnParameters[] = $row->getColumn($columnName);

core/DataTable/Filter/ReplaceColumnNames.php

@@ -81,7 +81,7 @@ class ReplaceColumnNames extends BaseFilter
      */
     protected function filterTable($table)
     {
-        foreach ($table->getRows() as $key => $row) {
+        foreach ($table->getRows() as $row) {
             $oldColumns = $row->getColumns();
             $newColumns = $this->getRenamedColumns($oldColumns);
             $row->setColumns($newColumns);

core/DataTable/Map.php

@@ -104,7 +104,7 @@ class Map implements DataTableInterface
      */
     public function filter($className, $parameters = array())
     {
-        foreach ($this->getDataTables() as $id => $table) {
+        foreach ($this->getDataTables() as $table) {
             $table->filter($className, $parameters);
         }
     }

core/DataTable/Renderer/Rss.php

@@ -184,7 +184,6 @@ class Rss extends Renderer
             }
         }
         $html .= "\n</tr>";
-        $colspan = count($allColumns);
 
         foreach ($tableStructure as $row) {
             $html .= "\n\n<tr>";

core/DataTable/Renderer/Xml.php

@@ -373,7 +373,7 @@ class Xml extends Renderer
 
             // Handing case idgoal=7, creating a new array for that one
             $rowAttribute = '';
-            if (($equalFound = strstr($rowId, '=')) !== false) {
+            if (strstr($rowId, '=') !== false) {
                 $rowAttribute = explode('=', $rowId);
                 $rowAttribute = " " . $rowAttribute[0] . "='" . $rowAttribute[1] . "'";
             }

core/FrontController.php

@@ -390,7 +390,7 @@ class FrontController extends Singleton
 
             // ensure the current Piwik URL is known for later use
             if (method_exists('Piwik\SettingsPiwik', 'getPiwikUrl')) {
-                $host = SettingsPiwik::getPiwikUrl();
+                SettingsPiwik::getPiwikUrl();
             }
 
             /**
@@ -419,7 +419,7 @@ class FrontController extends Singleton
 
             // Force the auth to use the token_auth if specified, so that embed dashboard
             // and all other non widgetized controller methods works fine
-            if (($token_auth = Common::getRequestVar('token_auth', false, 'string')) !== false) {
+            if (Common::getRequestVar('token_auth', false, 'string') !== false) {
                 Request::reloadAuthUsingTokenAuth();
             }
             SettingsServer::raiseMemoryLimitIfNecessary();

core/IP.php

@@ -170,9 +170,8 @@ class IP
      */
     public static function isIPv4($ip)
     {
-        // in case mbstring overloads strlen and substr functions
+        // in case mbstring overloads strlen function
         $strlen = function_exists('mb_orig_strlen') ? 'mb_orig_strlen' : 'strlen';
-        $substr = function_exists('mb_orig_substr') ? 'mb_orig_substr' : 'substr';
 
         // IPv4
         if ($strlen($ip) == 4) {

core/SegmentExpression.php

@@ -63,7 +63,7 @@ class SegmentExpression
     public function parseSubExpressions()
     {
         $parsedSubExpressions = array();
-        foreach ($this->tree as $id => $leaf) {
+        foreach ($this->tree as $leaf) {
             $operand = $leaf[self::INDEX_OPERAND];
 
             $operand = urldecode($operand);
@@ -339,7 +339,6 @@ class SegmentExpression
         if (count($this->tree) == 0) {
             throw new Exception("Invalid segment, please specify a valid segment.");
         }
-        $bind = array();
         $sql = '';
         $subExpression = false;
         foreach ($this->tree as $expression) {

core/Tracker.php

@@ -411,8 +411,8 @@ class Tracker
             require_once PIWIK_INCLUDE_PATH . '/core/Loader.php';
             require_once PIWIK_INCLUDE_PATH . '/core/Option.php';
 
-            $access = Access::getInstance();
-            $config = Config::getInstance();
+            Access::getInstance();
+            Config::getInstance();
 
             try {
                 Db::get();

core/View/UIControl.php

@@ -136,7 +136,6 @@ class UIControl extends \Piwik\View
         }
 
         $this->templateVars['clientSideParameters'] = array();
-        $clientSideParameters = $this->getClientSideParameters();
         foreach ($this->getClientSideParameters() as $name) {
             $this->templateVars['clientSideParameters'][$name] = $innerTemplateVars[$name];
         }