- juil. 11, 2014
-
-
Thomas Steur a rédigé
-
Thomas Steur a rédigé
-
Thomas Steur a rédigé
-
Thomas Steur a rédigé
those example dimensions were not moved from core to plugins, we should make sure they are getting installed
-
Thomas Steur a rédigé
-
Thomas Steur a rédigé
-
Thomas Steur a rédigé
just noticed I broke the installer when I was trying to fix the updater in c01d57bc, this might work... basically the idea was ok but we should check for this only if the column actually already exists. If the column does not exist yet we need to make sure it will be installed
-
Thomas Steur a rédigé
-
- juil. 08, 2014
-
-
Thomas Steur a rédigé
this is a very complicated one. Problem was when updating from 2.4.0 to 2.5.0-b1 the updater wanted to update all dimensions (meaning alter all columns in log_visit, link_action and conversion) to the same column type. This was happening because the system did not know those dimensions were already installed from a previous Piwik version. There was an update script that was supposed to tell Piwik those components are actually already installed since we only moved them from core to plugins but it cannot work as it is an update as well and therefore not executed before the actual update check. I tried many solutions to overcome this issue including reverting all the columns to the initial MySql Schema but even then there are problems as some plugins like DevicesDetection are not defined in MySql Schema but in the plugin. It is especially complicated since users might update from 2.4 to a future version where the column type of one of those dimension changes and we need to make sure to actually execute an alter update if one of those dimension changes. In such a case we cannot directly mark the component as successfully recorded. The conclusion was for me it is only possible to solve this problem by listing all dimensions that were moved from core to plugins including their version at that time hard coded...
-
Thomas Steur a rédigé
-
Thomas Steur a rédigé
-
Thomas Steur a rédigé
the horizontal scoll pane is not styled in segment editor, so make sure there is a space and it is possible to wrap the content to avoid horizontal scollbars
-
Thomas Steur a rédigé
-
- juil. 07, 2014
-
-
Thomas Steur a rédigé
refs #5409 #341 #5349 if a config value contains a dollar sign convert it to an html entity to prevent it being interpreted as a PHP variable. This allows us to remove the RAW ini parser flag which causes trouble on some PHP versions as the parser seems to be buggy.
-
Thomas Steur a rédigé
-
Thomas Steur a rédigé
updated submodule and increased version -> this might fix the updater ui test as it will then execute the update
-
Thomas Steur a rédigé
-
Matthieu Aubry a rédigé
provide a more useful error message on exception
-
Matthieu Aubry a rédigé
included default value for concurent threads number
-
Matthieu Aubry a rédigé
add XSD to PHPUnit configuration
-
Michał Gaździk a rédigé
-
Thomas Steur a rédigé
-
Thomas Steur a rédigé
-
Thomas Steur a rédigé
-
Thomas Steur a rédigé
-
Thomas Steur a rédigé
-
Thomas Steur a rédigé
-
diosmosis a rédigé
-
Thomas Steur a rédigé
-
Thomas Steur a rédigé
Conflicts: core/FrontController.php core/Log.php plugins/API/API.php tests/PHPUnit/Fixture.php tests/PHPUnit/UI
-
Thomas Steur a rédigé
this should make the documentation generator work again... it was not allowed to define view here as a class View already exists in that namespace
-
diosmosis a rédigé
-
Thomas Steur a rédigé
-
Thomas Steur a rédigé
i am getting closer... on Travis CI the ip is not anonymized when localtracker is used but it does locally
-
diosmosis a rédigé
-
Thomas Steur a rédigé
-
Thomas Steur a rédigé
log only calls to privacy manager changes and also log when fixtures are executed to see whether it actually executes them in same order
-
Thomas Steur a rédigé
-
Thomas Steur a rédigé
-
Thomas Steur a rédigé
If a dimension only implements a getName() method it should extend Dimension and not VisitDimension which is more "correct" and improves performance since we do not have to check whether they are installed and whether they implement certain methods
-