Allow new CustomVariable segments to provide all custom variable suggested values by allowing the suggestedValuesCallback to accept Live.getLastVisitDetails data.

Refactor API.getSegmentsMetadata and Plugin\Segment so segments are all defined through Plugin\Segment class in dimensions & make sure AutoSuggestAPITest data providers do not use database.

Use custom DefinitionSource to access TestingEnvironmentVariables so those variables can be easily overridden by test classes through provideContainerConfig(BeforeClass).

Refresh the Cache in tests so that custom variable max slot\ is properly initialised, and all segments are found

This one was not easy to find either. The segment value contained a
comma instead of a dot causing the API to not find anything and to not
return any data.

refs #5940 moved files into a subfolder framework, added autoloader to remove duplicated code to load autoload.php and to be able to register more autoloaders (eg for test files) on demand. This I got read of many includes that had to be updated all the time and that had to be updated all the time when moving iles

refs #5940 we might stay backwards compatible this way for 2 months. moved some tests from unit to integration and explained when a test is a unit test, an integration test or a system test.

refs #5940 put tests in correct folders, better testsuite names, some tests still fail and I cannot figure out why

  - moved all API URL generation logic & API response handling logic to separate classes
  - created ApiTestConfig class to hold API test options (and documentation for properties)
  - remove unnecessary IntegrationTestCase properties and methods (including apiNotToCall/apiToCall)
  - remove as many unnecessary API test options as possible (including abandonedCarts, hackDeleteRangeArchivesBefore)
  - rename checkRequestResponse to assertApiResponseHasNoError

Refs #5800, add namespaces to integration tests in root folder. Also add IntegrationTestCase to a namespace, re-add individual test @groups, move test groups to class level, and rename test files & class names so underscores are not used.

Piwik is a free/libre analytics platform. Refs #4455 GNU Package requirement to use free/libre instead of open source

They pass locally.
CI-only build errors, my pleasure.

Trying to fix: PHP Fatal error:  Call to a member function getCurrency() on a non-object in /home/travis/build/piwik/piwik/plugins/Live/API.php on line 554
https://travis-ci.org/piwik/piwik/jobs/22318726
Note: this should not happen really and I'm puzzled... especially as it works on other PHP versions...

Trying to fix: PHP Fatal error:  Call to a member function getCurrency() on a non-object in /home/travis/build/piwik/piwik/plugins/Live/API.php on line 554
https://travis-ci.org/piwik/piwik/jobs/22318726
Note: this should not happen really and I'm puzzled... especially as it works on other PHP versions...

Trying to fix: PHP Fatal error:  Call to a member function getCurrency() on a non-object in /home/travis/build/piwik/piwik/plugins/Live/API.php on line 554
https://travis-ci.org/piwik/piwik/jobs/22318726
Note: this should not happen really and I'm puzzled... especially as it works on other PHP versions...

- Rename *_BaseFixture to Fixture.
- Move DB setup code to Fixture and reuse code in DatabaseTestCase.
- Make IntegrationTestCase::$defaultApiNotToCall an instance var.

Fix bug (missing getInstance()). Exception was not shown because tests were not rethrowing the exception

Added namespaces to functions.php files in the five plugins that had one
Work in progress

Removed many Piwik_ functions, in Piwik 2 it is best practise to use the methods calls instead

Todo: finish converting core/ classes + convert plugins/ classes to use \Piwik\Plugin namespace + fix build + Merge master

Refs #4059 Work in progress: Conversion to use Namespaces: Period*, Metrics, Segment, SegmentExpression, PluginsManager.
Removed some deprecated code.

 * new segment 'siteSearchKeyword'
Fixes #3903, #3905:
 * adding few fields in the Live API output to accomodate getSuggestedValuesForSegment
 * renamed other fields for consistency with segment names
Fixes #3906:
 * new API: getSuggestedValuesForSegment which returns top suggested values for a particular segment. It uses the Live.getLastVisitsDetails API to fetch the most recently used values, and will show the most used values first

 * Adding tests for everything. The test case actually generates data for all segments so that VisitsSummary.get returns some data for each of the 47 segments being tested returns some data.
  How it works:
  * generate extended data in fixture
  * Tests (1) call getSuggestedValuesForSegment for each segment, check there is some data returned for each segment
  * get the first suggested value from the list,
  * Tests (2) call VisitsSummary.get with this segment value, eg. countryCode==ru.
    * I worked this way for all 47 segments until all tests had some data ==> now we know that all segments have been tested and that the auto suggest works for all segments. TDD FTW!