Skip to content
Extraits de code Groupes Projets
Valider b2904051 rédigé par diosmosis's avatar diosmosis
Parcourir les fichiers

Tweaking docs and removing TODOs.

parent da1ffe66
Aucune branche associée trouvée
Aucune étiquette associée trouvée
Aucune requête de fusion associée trouvée
...@@ -12,7 +12,10 @@ namespace Piwik\API; ...@@ -12,7 +12,10 @@ namespace Piwik\API;
* to provide a way to clean up existing Piwik code and behavior without breaking * to provide a way to clean up existing Piwik code and behavior without breaking
* backwards compatibility immediately. * backwards compatibility immediately.
* *
* Should be removed before releasing Piwik 3.0. [TODO: note in issue about 3.0.] * Code that handles the case when the 'format_metrics' query parameter value is
* 'bc' should be removed as well. This code is in API\Request and DataTablePostProcessor.
*
* Should be removed before releasing Piwik 3.0.
*/ */
class Inconsistencies class Inconsistencies
{ {
......
...@@ -93,7 +93,6 @@ class Request ...@@ -93,7 +93,6 @@ class Request
$defaultRequest['segment'] = $requestRaw['segment']; $defaultRequest['segment'] = $requestRaw['segment'];
} }
// TODO: comment on why this code is here, and make sure to mention in Inconsistencies class
if (empty($defaultRequest['format_metrics'])) { if (empty($defaultRequest['format_metrics'])) {
$defaultRequest['format_metrics'] = 'bc'; $defaultRequest['format_metrics'] = 'bc';
} }
......
...@@ -232,7 +232,7 @@ class API extends \Piwik\Plugin\API ...@@ -232,7 +232,7 @@ class API extends \Piwik\Plugin\API
// First rename the avg_price_viewed column // First rename the avg_price_viewed column
$renameColumn = array(self::AVG_PRICE_VIEWED => 'avg_price'); $renameColumn = array(self::AVG_PRICE_VIEWED => 'avg_price');
$dataTable->filter('ReplaceColumnNames', array($renameColumn)); // TODO: benchmark this change $dataTable->filter('ReplaceColumnNames', array($renameColumn));
$dataTable->queueFilter('ReplaceColumnNames'); $dataTable->queueFilter('ReplaceColumnNames');
$dataTable->queueFilter('ReplaceSummaryRowLabel'); $dataTable->queueFilter('ReplaceSummaryRowLabel');
......
...@@ -46,7 +46,7 @@ abstract class GoalSpecificProcessedMetric extends ProcessedMetric ...@@ -46,7 +46,7 @@ abstract class GoalSpecificProcessedMetric extends ProcessedMetric
$this->idGoal = $idGoal; $this->idGoal = $idGoal;
} }
protected function getColumnPrefix() // TODO: should cache this information somehow protected function getColumnPrefix()
{ {
return 'goal_' . $this->idGoal; return 'goal_' . $this->idGoal;
} }
......
0% Chargement en cours ou .
You are about to add 0 people to the discussion. Proceed with caution.
Terminez d'abord l'édition de ce message.
Veuillez vous inscrire ou vous pour commenter